caliburn Issue Tracker Rss Feed

Commented Issue: Make PropertyChangedBase.PropertyChanged virtual [4672]

EisenbergEffect — Sun, 15 Nov 2009 23:11:05 GMT

The PropertyChanged event in PropertyChangedBase is not virtual. This causes problems if you use it as a base class for objects that are persisted using NHibernate (which needs all public members to be virtual). As a result, on the project I'm currently working on, we've had to create a copy of the class to use.

Would making the event virtual cause any unforeseen issues that I may not have thought of?

Created Issue: Make PropertyChangedBase.PropertyChanged virtual [4672]

adamconnelly — Sat, 14 Nov 2009 18:22:01 GMT

Commented Issue: Improved parameter parsing [4644]

EisenbergEffect — Wed, 11 Nov 2009 15:56:12 GMT

e.g. trying to pass a colon as a parameter like this: ...Attach="PressKey(',')" doesn't work (but did with an earlier version, even without quotes).

I think the parameter parsing can be improved a little bit. The attached patch (tests included) allows the following literal parameters:

Attach="Foo" // no param
Attach="Foo()" // still no param
Attach="Foo(1,2,3)" // numerics
Attach="Foo('bar', 'baz')" // strings
Attach="Foo('b(a)r', 'b(a)z')" // strings with parenthesis
Attach="Foo('b''ar')" // strings with escaped quote in the middle
Attach="Foo('''bar''')" // strings with escaped quote at the beginning/end
Attach="Foo('bar,baz')" // strings string containing colon

Created Issue: Improved parameter parsing [4644]

etobi — Wed, 11 Nov 2009 15:18:28 GMT

Closed Issue: Register Instance Support [4370]

EisenbergEffect — Tue, 10 Nov 2009 04:44:33 GMT

Many IoC Containers allow you to register an instance of a class. This feature would help with Prism Integration
see http://caliburn.codeplex.com/Thread/View.aspx?ThreadId=71711 for reference

Closed Issue: LOB Sample Bug [4384]

EisenbergEffect — Fri, 16 Oct 2009 22:09:18 GMT

See http://caliburn.codeplex.com/Thread/View.aspx?ThreadId=71929
Comments:

Fixed as of revision 32646.

Closed Issue: Default Binder Protected Methods [4383]

EisenbergEffect — Thu, 15 Oct 2009 17:05:24 GMT

Make more of the binder's methods protected so that it is easier for developers to customize.
Comments:

Fixed.

Created Issue: LOB Sample Bug [4384]

EisenbergEffect — Thu, 15 Oct 2009 05:14:41 GMT

See http://caliburn.codeplex.com/Thread/View.aspx?ThreadId=71929

Created Issue: Default Binder Protected Methods [4383]

EisenbergEffect — Thu, 15 Oct 2009 05:13:49 GMT

Make more of the binder's methods protected so that it is easier for developers to customize.

Commented Issue: Register Instance Support [4370]

EisenbergEffect — Tue, 13 Oct 2009 18:16:56 GMT

Many IoC Containers allow you to register an instance of a class. This feature would help with Prism Integration
see http://caliburn.codeplex.com/Thread/View.aspx?ThreadId=71711 for reference
Comments: ** Comment from web user: EisenbergEffect **

Definitely in v2.

Created Issue: Register Instance Support [4370]

rauh_ryan — Tue, 13 Oct 2009 13:50:59 GMT

Many IoC Containers allow you to register an instance of a class. This feature would help with Prism Integration
see http://caliburn.codeplex.com/Thread/View.aspx?ThreadId=71711 for reference

Commented Issue: Binding Testing [3964]

brettright — Sat, 12 Sep 2009 11:31:43 GMT

Binding Testing
Hi I have started using Caliburn. I am very excited by the project. Gr8 work.
One of the key problems I have had with WPF MVVM architectures is that there is always a suggestion that you move all yr logic 2 the VM and then you test this.
You use bindings between the View and the View model and leave the View untested.
This sounds gr8 but I really find this fragile so Testing the bindings appears to me to be critical.
Unfortunately I am having the following problems when trying to test the Bindings.

When executing this test
[Test]
public void Test()
{
CrossThreadRunner runner = new CrossThreadRunner();
runner.RunInSTA(delegate
{
BindingValidator<ShellPresenter> validator =
Validator.For<ShellView, ShellPresenter>();
ValidationResult<ShellPresenter> result = validator.Validate();

Assert.That(result.HasErrors, Is.False, result.ErrorSummary);
});
//The Validator class has several 'For' methods. In this case we are using the overload that
//takes a type parameter for the UI and a type parameter for the bound data type.
//Simply call the Validate method and check the results to insure that all your binding expressions
//are correct. The ErrorSummary contains a textual representation of any errors that are found.
//The framework will walk the entire UI hierarchy checking data bindings on all dependency properties. It will check all elements for inline DataTemplates (such as ItemsControl.ItemTemplate) and, if found, check the template. All inline styles will be checked. Triggers on both DataTemplate and Style will also be checked.
}

With the Shell xaml
<Button Content="Click Me!" cal:Message.Attach="BoundCommand TheCommandForTest(SomethingWasDone.Text)" />

I get the following error.

TestShellView.Test : FailedSystem.InvalidOperationException: The calling thread cannot access this object because a different thread owns it.
at System.Windows.Threading.Dispatcher.VerifyAccess()
at System.Windows.Threading.DispatcherObject.VerifyAccess()
at System.Windows.DependencyObject.GetValue(DependencyProperty dp)
at System.ComponentModel.DesignerProperties.GetIsInDesignMode(DependencyObject element)
at Caliburn.PresentationFramework.PresentationFrameworkModule.get_IsInDesignMode() in c:\Brett\temp\Caliburn v1 Release Candidate 2\Source\src\Caliburn.PresentationFramework\PresentationFrameworkModule.cs: line 37
at Caliburn.PresentationFramework.Commands.CommandMessage..ctor() in CommandMessage.wpf.cs: line 94
System.Windows.Markup.XamlParseException: 'BoundCommand TheCommandForTest(SomethingWasDone.Text)' value cannot be assigned to property 'Attach' of object 'System.Windows.Controls.Button'. The calling thread cannot access this object because a different thread owns it. Error at object 'System.Windows.Controls.Button' in markup file 'CMCaliburn;component/views/shellview.xaml' Line 11 Position 37.
at System.Windows.Markup.XamlParseException.ThrowException(String message, Exception innerException, Int32 lineNumber, Int32 linePosition, Uri baseUri, XamlObjectIds currentXamlObjectIds, XamlObjectIds contextXamlObjectIds, Type objectType)
at System.Windows.Markup.XamlParseException.ThrowException(ParserContext parserContext, Int32 lineNumber, Int32 linePosition, String message, Exception innerException)
at System.Windows.Markup.BamlRecordReader.ThrowExceptionWithLine(String message, Exception innerException)
at System.Windows.Markup.BamlRecordReader.ReadPropertyRecordBase(String attribValue, Int16 attributeId, Int16 converterTypeId)
at System.Windows.Markup.BamlRecordReader.ReadPropertyConverterRecord(BamlPropertyWithConverterRecord bamlPropertyRecord)
at System.Windows.Markup.BamlRecordReader.ReadRecord(BamlRecord bamlRecord)
at System.Windows.Markup.BamlRecordReader.Read(Boolean singleRecord)
at System.Windows.Markup.TreeBuilderBamlTranslator.ParseFragment()
at System.Windows.Markup.TreeBuilder.Parse()
at System.Windows.Markup.XamlReader.LoadBaml(Stream stream, ParserContext parserContext, Object parent, Boolean closeStream)
at System.Windows.Application.LoadComponent(Object component, Uri resourceLocator)
at CMCaliburn.Views.ShellView.InitializeComponent() in ShellView.xaml: line 1
at CMCaliburn.Views.ShellView..ctor() in ShellView.xaml.cs: line 10
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
at System.RuntimeTypeHandle.CreateInstance(RuntimeType type, Boolean publicOnly, Boolean noCheck, ref Boolean canBeCached, ref RuntimeMethodHandle ctor, ref Boolean bNeedSecurityCheck)
at System.Activator.CreateInstance<T>()
at Caliburn.Testability.Validator.For<Element,Type>() in c:\Brett\temp\Caliburn v1 Release Candidate 2\Source\src\Caliburn.Testability\Validator.cs: line 21
at TestCMCaliburn.TestShellView.<Test>b__0() in TestShellView.cs: line 30
at Habanero.Util.CrossThreadRunner.MultiThreadedWorker(ThreadStart userDelegate) in D:\Systems\Habanero\trunk\source\Habanero.Base\Util\CrossThreadRunner.cs: line 114
at Habanero.Util.CrossThreadRunner.ThrowExceptionPreservingStack(Exception exception) in D:\Systems\Habanero\trunk\source\Habanero.Base\Util\CrossThreadRunner.cs: line 134
at Habanero.Util.CrossThreadRunner.Run(ThreadStart userDelegate, ApartmentState apartmentState) in D:\Systems\Habanero\trunk\source\Habanero.Base\Util\CrossThreadRunner.cs: line 107
at Habanero.Util.CrossThreadRunner.RunInSTA(ThreadStart userDelegate) in D:\Systems\Habanero\trunk\source\Habanero.Base\Util\CrossThreadRunner.cs: line 78
at TestCMCaliburn.TestShellView.Test() in TestShellView.cs: line 28
Comments: ** Comment from web user: brettright **

Got the latest source and it works great now thanks a million
brett

Closed Issue: Binding Testing [3964]

EisenbergEffect — Thu, 10 Sep 2009 15:45:22 GMT

Fixed (I hope) as of revision 27965. If not, there is nothing I can do about this. You will need to change the way your are running STA. Many unit test frameworks have a configuration setting for this.

Created Issue: Binding Testing [3964]

brettright — Thu, 10 Sep 2009 14:34:57 GMT

Closed Issue: Prism, Caliburn - Module not loading using Caliburn Presentation Framework [3903]

EisenbergEffect — Tue, 08 Sep 2009 15:54:07 GMT

I am attempting to convert a project I have from using a homegrown presentation MVVM framework I used to Caliburn's Presentation framework. I have carefully used the Caliaburn LOB WPF sample app to attempt this. I certainly hope I'm missing something very obvious, but I can't seem to find out what is going on here.

I have a UI Shell project. The Shell's ViewModel has a property of type IPresenterManager called DocumentController. DocumentController.Presenters is bound to a TabControl's ItemsSource. The TabControl's SelectedItem property is bound to DocumentController.CurrentPresenter.

I have an IPresenter, in a different assembly, that is loaded by Prism, a reference to the DocumentController is retrieved, and I call Open like so:

documentController.Open(new Activity.ViewModels.DebtsModel());

The odd thing is, not only does my View not render (which could be due to the DefaultViewStrategy mishaps, although I think my namespace conventions follow the documentation), but the bound Presenters collection in the Shell does not seem to be updating when the module adds a presenter.

Discussion link:
http://caliburn.codeplex.com/Thread/View.aspx?ThreadId=67660

-Josh
Comments:

Provided a solution.

Closed Issue: strange problem intercepting viewmodels [3763]

EisenbergEffect — Tue, 08 Sep 2009 15:30:03 GMT

I've an strange issue when I add a custom interceptor for a viewmodel component in my castle container.

The problem is with PropertyChanged notifications,... seems to never reach the client api.

The issue is not related to castle because I already test in isolation... but I'm not sure.

I will attach a sample project.
Comments:

Suggested a work around. Will work to address this problem more directly in v2.

Commented Issue: strange problem intercepting viewmodels [3763]

EisenbergEffect — Tue, 08 Sep 2009 15:28:58 GMT

It seems there is a problem with DynamicProxy. I think this could be mitigated by providing Caliburn with a custom implementation of IActionFactory. I would recommend inheriting from ActionFactory and overriding SelectMethods. You could then inspect the proxy type for a predefined marker which would tell you the underlying type. You could then pass that into the base SelectMethods. I will try and investigate this further for v2 of Caliburn because I would like to provide the proxy functionality out of the box.

Commented Issue: Prism, Caliburn - Module not loading using Caliburn Presentation Framework [3903]

EisenbergEffect — Tue, 08 Sep 2009 14:12:11 GMT

OK. I have found the problems. There are several, but they are very easy to fix.

1. When you register your DocumentController in the Bootstrapper, you are registering it as a PresenterManager, but it should be a MultiPresenterManager.
2. Once you fix the above, you will then have an exception from the DefaultViewStrategy because your namespaces are not quite right. For example, you called the class DebtsModel, but put it in a namespace called ViewModels. If you want to call it DebtsModel, the namespace should be called Models or you could change the class to DebtsViewModel if you want the namespace to be called ViewModels.
3. Once you fix that, you will get some databinding errors because your DisplayName and Description properties on the DebtsModel are readonly. You will either need to change the binding mode or make them read/write properties.

Commented Issue: Setting dialog result from presenter [3926]

marcoamendola — Tue, 08 Sep 2009 13:52:30 GMT

I couldn't find a way to set the dialog result from a presenter living within a dialog window.
A proposed implementation is attached.
Comments: ** Comment from web user: marcoamendola **

I was wrong: the scenario with window wrapper created by DefaultWindowManager is working perfectly.
I didn't noticed that the model is actually bound to the wrapping window, not the contained view.

Reopened Issue: Prism, Caliburn - Module not loading using Caliburn Presentation Framework [3903]

pianomanjh — Mon, 07 Sep 2009 20:35:22 GMT

Thanks for the response on this. Unfortunately, altering the code as you describe to ensure a single container does not solve the issue. The object reference is indeed added/retrieved from the correct container as I see it, but the Binding is not taking place. I have re-attached a solution, with your changes, and also with all the Libraries I am using (I am using a post R2 release of Caliburn). Hopefully you'll be able to compile the solution as is.
Thanks for taking the time on this.
-Josh